radicle-interface icon indicating copy to clipboard operation
radicle-interface copied to clipboard

Add route support to vesting feature

Open sebastinez opened this issue 2 years ago • 1 comments

This allows people to either search for their vesting contract through the search form or visit directly vesting/<contract address>

Was not able to test withdraw functionality, but this PR does not touch it, so should be fine.

Small example on the functionality

https://user-images.githubusercontent.com/7912302/203993327-8d2d0e8b-da1a-4001-97dc-945045cb6368.mov

sebastinez avatar Nov 25 '22 13:11 sebastinez

Was going to suggest this :+1:

cloudhead avatar Nov 26 '22 14:11 cloudhead

Looks like there are new fields: start time, cliff period end and vesting period end now. Wondering if we should show the timestamp?

Screenshot 2022-12-01 at 17 46 49

rudolfs avatar Dec 01 '22 16:12 rudolfs

Looks like there are new fields: start time, cliff period end and vesting period end now. Wondering if we should show the timestamp?

The idea behind the additional timestamps is to allow users that don't know how to extract information easily out of a smart contract, to get the dates of their vesting information.

Since we don't show or have any personal identification related to the contracts I think we should be fine

Or do you have any particular concerns in showing the timestamps?

sebastinez avatar Dec 01 '22 18:12 sebastinez

Ok wrt to some tests, I think we would need for the JsonRpcProvider refactor PR to happen, before this can be tested thorougly.

sebastinez avatar Dec 01 '22 20:12 sebastinez

Or do you have any particular concerns in showing the timestamps?

Oh, it was more about the actual time part: 00:00:00 GMT. Can we drop that?

rudolfs avatar Dec 01 '22 21:12 rudolfs

Oh, it was more about the actual time part: 00:00:00 GMT. Can we drop that?

da0d980c Bildschirm­foto 2022-12-02 um 06 48 55

sebastinez avatar Dec 02 '22 05:12 sebastinez