Aleksandar Vacić

Results 41 comments of Aleksandar Vacić

@kylef, I'm not sure what's the idea with your master branch, as it seems you removed the project and podspec. In case anyone needs to use this as CocoaPod, take...

@SamMcNeilly Like this: `pod 'JSONWebToken', :git => 'https://github.com/radianttap/JSONWebToken.swift.git', :branch => 'podspec' `

Thanks for this, will need to check how it works. But before merging, please re-indent the code using tabs, as the rest of the project uses Tabs. (Having tabs and...

Not sure, will need to check this out.

If the `animated: false` is sent, both on presenting and dismissing, these respective methods are not called: ``` func animationController(forPresented presented: UIViewController, presenting: UIViewController, source: UIViewController) -> UIViewControllerAnimatedTransitioning? func animationController(forDismissed...

In order to perform required visual changes, I need access to `UIViewControllerContextTransitioning` which is not available anywhere I can see except inside the `animateTransition(using transitionContext: UIViewControllerContextTransitioning)` which is not called...

This is nice catch. I'll look into this as soon as I have time.

Thinking out-loud...it seems to me in all these cases where I just `return` from the `didShowController(_)`, I should actually call `parent?.coordinatorDidFinish(self, completion: {})` ```swift guard let index = viewControllers.firstIndex(of: viewController)...

It means there is no tag for such a version. Since this lib is now at 5.0.3, this is resolved a while ago. Should be closed.

I never used Travis thus I have no idea what to edit. I believe owners can edit the PR..?