prescient.el icon indicating copy to clipboard operation
prescient.el copied to clipboard

company-lsp example: is it still appropriate/relevant?

Open rdiaz02 opened this issue 3 months ago • 2 comments

In https://github.com/radian-software/prescient.el#for-company we are told:

"By customizing this user option to nil for such Company backends (see Radian for an example)"

and the example code uses company-lsp, but company-lsp is no longer supported : https://emacs-lsp.github.io/lsp-mode/#overview " (note that company-lsp is no longer supported)." Also tigersoldier/company-lsp#145 (comment) (from LSP developer, August 2020).

So I wonder if:

  1. The problem is still present (does not seem so in my very limited testing with only a few languages)
  2. If the problem should be addressed via a package that is no longer supported.

(Note: this is strongly related to similar comments in https://github.com/radian-software/radian/issues/535)

rdiaz02 avatar Mar 15 '24 13:03 rdiaz02

Well, no comment is made on the prescient.el side about company-lsp specifically, it is just that that is what is used on the Radian side. No objection to using a different example, if there is another good one.

raxod502 avatar Mar 23 '24 01:03 raxod502

My suggestion would be to comment out in here since: a) I think the problem is not present; b) it refers to a package no longer supported. But then, I am not 100% sure. So, of course, feel free to close this as irrelevant noise if it is :-)

rdiaz02 avatar Mar 23 '24 13:03 rdiaz02