prescient.el icon indicating copy to clipboard operation
prescient.el copied to clipboard

ivy-resume is broken with ivy-prescient

Open p1llule opened this issue 3 years ago • 2 comments

Hi.

ivy-resume can be used with a argument to restore a previous ivy session.

This doesn't work with ivy-prescient installed.

Steps to reproduce :

  1. have ivy and ivy-prescient enabled.
  2. register an ivy session (eg: call M-x or wathever)
  3. C-u ivy-resume
  4. ivy-prescient-sort-function: Wrong type argument: sequencep, counsel-M-x

My workaround for the time being is : (add-to-list 'ivy-sort-functions-alist (list 'ivy-resume))

oh and I have this config from doom @hlissner which already exclude ivy-resume but that's not relevant here. (setq ivy-prescient-sort-commands '(:not swiper swiper-isearch ivy-switch-buffer ivy-resume ivy--restore-session lsp-ivy-workspace-symbol counsel-grep counsel-git-grep counsel-rg counsel-ag counsel-ack counsel-fzf counsel-pt counsel-imenu counsel-yank-pop counsel-recentf counsel-buffer-or-recentf) ivy-prescient-retain-classic-highlighting t)

p1llule avatar Mar 10 '21 04:03 p1llule

I suppose there is something more elegant to do but waiting advice,

p1llule avatar Mar 10 '21 04:03 p1llule

Thanks, also see https://github.com/raxod502/prescient.el/issues/65

clemera avatar Mar 11 '21 11:03 clemera