react-native-radar icon indicating copy to clipboard operation
react-native-radar copied to clipboard

Update to Radar Android SDK 3.2.2

Open phil-brown opened this issue 3 years ago • 5 comments

These changes update the Android side of things - adds the Radar SDK 3.2.2 and updates the Gradle and AGP versions. It also adds some static analysis checks and updates Android Permission checks. Finally, this PR also adds support for setting the publishable key in strings.xml instead of in code.

phil-brown avatar Nov 11 '21 16:11 phil-brown

https://app.shortcut.com/radarlabs/story/7670

tjulien avatar Nov 11 '21 16:11 tjulien

This pull request has been linked to Shortcut Story #7670: Upgrade React Native to Android 3.2.

This changes the recommended configuration that we should document in react docs, such that the method RNRadar.initialize should be used instead of Radar.initialize.

Is this a breaking change? Or will previous methods of initialization still work?

kochis avatar Nov 11 '21 16:11 kochis

@kochis yes. If the apps use Kotlin, then it will be less noticeable, since initialization of Radar without a receiver will work, as it will default to null (which could be really bad). For Java, they will be forced to specify the receiver. They can either use new RNRadarReceiver() here, or use the RNRadar.initialize method. Do we need to make a change to the Android SDK so this won't occur on Kotlin implementations, and/or add a migration guide? https://github.com/radarlabs/radar-sdk-android/blob/master/MIGRATION.md#31x-to-32x

phil-brown avatar Nov 11 '21 16:11 phil-brown

@tjulien can you review?

phil-brown avatar Feb 14 '22 15:02 phil-brown