Andrew Murray

Results 761 comments of Andrew Murray

> What about TiffImagePlugin? Can we call super().seek() there? No, because at the end of TiffImagePlugin's `seek()`, the normal size isn't used - `self._tile_size` is.

I don't think this is the neatest API change I've ever suggested, so if there isn't much interest, I'm happy for this to be closed.

Are you able to put together a small self-contained example to demonstrate? Maybe even attach a copy of the binary?

How would you feel if we just improved XPM support? Would you mind copying [hopper.png](https://github.com/python-pillow/Pillow/blob/main/Tests/images/hopper.png), and then using this code to save the file, ```python import subprocess args = ["wl-paste",...

I've created #8874 to resolve this. I've included your image, which I've named hopper_rgb.xpm. If the PR is merged, the test image will be distributed under our license.

I noticed that the deprecation warning wasn't being emitted for ```python from PIL import Image im = Image.new("I", (1, 1)) im.save("out.png") ``` This is because the call to `deprecate()` isn't...

> Should we just have a pointer to the mode struct? This makes more changes across the code base. Could you clarify for me, what was the motivation behind the...

Considering there's an [open discussion about forcing Python to require zlib](https://discuss.python.org/t/lets-make-zlib-required-rather-than-optional-to-build-cpython/23062/22), I don't think this is purely about the Python version, but rather about how you installed one version vs...

> Only the b"\xff\xd8" marker is problematic - when I remove it, the test passes again. I think you meant b'\xff\xc4'. That's the `marker` value in your error. As you...

I've created https://github.com/python-pillow/Pillow/pull/9025 to only check the DHT marker if libjpeg-turbo is being used.