Andrew Murray

Results 761 comments of Andrew Murray

Hi. I've created #8983. Let me know if you think I've missed anything.

The simplest option would be to just - add the relevant *.pyi files alongside the existing *.py files as per https://peps.python.org/pep-0484/#storing-and-distributing-stub-files, and - add a `py.typed` file as per https://peps.python.org/pep-0561/#packaging-type-information...

Let me know if there is any further work that would help this progress.

Sure. I've added a comment for one, and figured out alternatives for the others.

No worries, I understand there are many other PRs that come in. Thanks very much

I think #1110 would help this somewhat, but it has been stalled for a while.

> I tried converting "1.eps" to PNG using ImageMagick, and it converted it to a 72x48 sized image. So perhaps Pillow isn't using the right size either. Not that there...

Could you give an example of how to trigger this error?

Would it not be more consistent with the rest of TiffImagePlugin to log the extra information instead? https://github.com/python-pillow/Pillow/blob/eeb3d04843996117457af2481ca242f97e646b5e/src/PIL/TiffImagePlugin.py#L1429-L1435

> With #8317, `test_bigtiff()` in `test_file_tiff.py` triggers this error if `del im.tag_v2[273]` is removed from the test. Just a note: this specific example stopped triggering the error after #8417 added...