Andrew Murray

Results 764 comments of Andrew Murray

Would that be sufficient to resolve this, or do you think that the image is valid and further investigation should be done into reading the layers?

If we were to figure out the error, then the 'blue 1' layer would be readable. However, the 'blue' layer would still not be, as Pillow doesn't currently support reading...

Pillow 10.4.0 has just been released with https://github.com/python-pillow/Pillow/pull/8039

@aclark4life is this still something on your to-do list, or should someone else take a crack at it?

> it doesn't seem like it's possible to use the other four. The following code will reach one of those lines. ```python from PIL import ImageCms source_profile = ImageCms.createProfile("sRGB") destination_profile...

From a documentation perspective, https://pillow.readthedocs.io/en/stable/reference/ImageCms.html#PIL.ImageCms.buildTransform describes `inMode` and `outMode` as > String, as a valid PIL mode that the appropriate profile also supports (i.e. “RGB”, “RGBA”, “CMYK”, etc.) Those are...

Would updating the documentation be sufficient to resolve this?

I've created https://github.com/python-pillow/Pillow/pull/8031 to resolve this by deprecating the unexpected modes, and adding replacements for some.

These modes aren't actually used by any image format (the rawmodes are, but not the modes). So a discussion about how they should behave is just about consistency with how...

I've created #7978 to deprecate them. > Slightly changing how they work doesn't require a deprecation period, so it could be done at the same time. The modes are currently...