Andrew Murray

Results 761 comments of Andrew Murray

Our habit is to add tests with PRs. This helps prevent regressions in the future. If you're someone who works with BC6 images, do you happen to have an image...

I've created https://github.com/ShadelessFox/Pillow/pull/1 to add Python bindings. Just making sure there is an explanation of the change here - you looked at the code, and as per https://docs.microsoft.com/en-us/windows/win32/direct3d11/bc6h-format#transform-inversion-for-endpoint-values, saw that...

Not a problem. It's good to be able to look back and understand where the changes came from.

I'm not aware of any problems at the moment, and you've added tests, so it's just a matter of myself or someone else finding the time to review. The Valgrind...

Interestingly, I found that Table 58 at https://registry.khronos.org/DataFormat/specs/1.1/dataformat.1.1.html#_bc6h has some mistakes in it (e.g. Mode 1, Bit 4 should be G35 as per Table 57). Everything in this PR makes...

There is an open issue for multichannel floating point images - #1888. I'm not following why that should lead to washed-out colors though? If I remove the gamma correction, then...

Russrite.ttf, woodcut.ttf and xfiles.ttf also work with `encoding="armn"`, and Hombre__.ttf doesn't even need encoding to be specified to work. @nulano is there anything left to do here, or is this...

Trying to replicate this, on Windows, I get > ValueError: array is too big; `arr.size * arr.dtype.itemsize` is larger than the maximum possible size. on Ubuntu, I get > MemoryError:...

The way to specify the "append" parameter that you have linked to is ```python a.save("out.tiff", format="tiff", quality=80, append=True) ``` However, when Pillow talks about appending, it's talking about adding another...

No, you don't need to create a new issue. I was just pointing that out.