sdb icon indicating copy to clipboard operation
sdb copied to clipboard

Kill SdbHt or Ht

Open radare opened this issue 6 years ago • 4 comments

i would go for ht. this means that r2 cant use this api screen shot 2018-05-09 at 16 48 32

radare avatar May 09 '18 15:05 radare

is this the dict api?

condret avatar May 09 '18 21:05 condret

No

On 9 May 2018, at 23:55, condret [email protected] wrote:

is this the dict api?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

radare avatar May 10 '18 07:05 radare

SdbHt defined in sdb/src/sdbht.h seems to be just an extension on top of sdb/src/ht.h.

Anyway, I would keep only ht.h as well. I've used it successfully in xrefs, we just need to reintroduce growing.

ret2libc avatar Jul 31 '18 15:07 ret2libc

The sdb prefix is to keep the namespace prefix in place and avoid conflicts with other hashtable implementations. If its a public api, aka used outside sdb it must keep that

On 31 Jul 2018, at 16:33, Riccardo Schirone [email protected] wrote:

SdbHt defined in sdb/src/sdbht.h seems to be just an extension on top of sdb/src/ht.h.

Anyway, I would keep only ht.h as well. I've used it successfully in xrefs, we just need to reintroduce growing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

radare avatar Jul 31 '18 16:07 radare