R2_590 change ESIL pop signature

[luc-tielen]

• [ ] Mark this if you consider it ready to merge
• [ ] I've added tests (optional)
• [ ] I wrote some lines in the book (optional)

Description

Merge #21886 first, also this doesn't fix all warnings yet..

[trufae]

comments on this @condret ?

[trufae]

Can you rebase this PR we should target r2-6.x now

[condret]

sorry for the late response. i'm not a fan of this. I don't see any necessity, and all these casts to char * feel bloaty to me. We can do this, if you really want this

[trufae]

Theres a noticeable perf boost by not strduping every word. Thats the reason behind this patch. So maybe the casts are ugly but i wanted to make clear the intentions behind

[condret]

can't we then just rm the strdups

[trufae]

Nope i tried. Some because invalid pointers. So we need again an abstraction over strings