radare2 icon indicating copy to clipboard operation
radare2 copied to clipboard

Init DAP protocol in IO plugin.

Open gogo2464 opened this issue 1 year ago • 6 comments

  • [ ] Mark this if you consider it ready to merge
  • [ ] I've added tests (optional)
  • [ ] I wrote some lines in the book (optional)

Description

Will solve: https://github.com/radareorg/radare2/issues/12128.

gogo2464 avatar Aug 14 '22 02:08 gogo2464

Thank you for review. I used this template: https://wenzel.github.io/2018/04/15/radare2-io-plugin-tutorial.html . Nothing is ready yet.

gogo2464 avatar Aug 15 '22 11:08 gogo2464

the error:

'/home/runner/work/radare2/radare2/libr/parse/p'
[1451](https://github.com/radareorg/radare2/actions/runs/3196044580/jobs/5217456357#step:7:1452)
tcc: error: file '/home/runner/work/radare2/radare2/libr/../shlr/dap/lib/libgdbr.a' not found
[1452](https://github.com/radareorg/radare2/actions/runs/3196044580/jobs/5217456357#step:7:1453)
make[3]: *** [/home/runner/work/radare2/radare2/libr/..//libr/rules.mk:91: libr_io.so] Error 1

the problem

LDFLAGS+=$(SHLR)/dap/lib/libgdbr.$(EXT_AR)

trufae avatar Oct 06 '22 11:10 trufae

@trufae fixed thank you so much!

For the other issues, this is just a template from internet. We could import the doc on r2book and r2 blog from https://wenzel.github.io/2018/04/15/radare2-io-plugin-tutorial.html and then update it.

EDIT : it has been merged but not published. https://github.com/radareorg/radare2-book/commit/fa8ef0f46dd0705019d0d376016a1effa0f8dad8

gogo2464 avatar Oct 07 '22 21:10 gogo2464

i cant repro the ptrace-attach problem you reported yesterday on the irc. the plugin is called and behaves as expected

trufae avatar Oct 09 '22 09:10 trufae

the failing linux-nocs job in the ci is because you are indenting with spaces instead of tabs. please run sys/lint.sh before commiting so you'll find some good hints to follow the coding style

trufae avatar Oct 09 '22 09:10 trufae

i cant repro the ptrace-attach problem you reported yesterday on the irc. the plugin is called and behaves as expected

I also used remote debuging from emulicious to test. Did you do so?

gogo2464 avatar Oct 09 '22 11:10 gogo2464