radare2 icon indicating copy to clipboard operation
radare2 copied to clipboard

Add REL bin plugin

Open riptl opened this issue 3 years ago • 7 comments

  • [x] Mark this if you consider it ready to merge
  • [x] I've added tests (optional)
  • [ ] I wrote some lines in the book (optional)

Description

https://wiki.tockdom.com/wiki/REL_(File_Format)

  • [x] Section loading
  • [x] Meson build
  • [x] Make build
  • [ ] Profiling / performance
  • [x] Fuzzing
  • [x] Internal relocs
  • [x] External relocs to ROM/symbols
  • [x] ~~External relocs to PIC/imports~~ (out of scope)
  • [ ] Test DOL/REL linking
  • [x] Add tests
  • [x] Formatting, code cleanup

Closes #20508

riptl avatar Jul 30 '22 09:07 riptl

[r] Cannot open '/Users/richard/prj/mkw/artifacts/orig/pal/StaticR.rel' 53

send this file to this repo https://github.com/radareorg/radare2-testbins/pulls

trufae avatar Jul 31 '22 13:07 trufae

Ready for review, pending merge of https://github.com/radareorg/radare2-testbins/pull/78

riptl avatar Aug 01 '22 12:08 riptl

libFuzzer found something 🗡️

% r2 -F rel oom-3852cb7a9012f8d9f2f3c21ad599c97b1caee477
INFO: REL module ID 00000003
INFO: REL version 3

zsh: segmentation fault  r2 -F rel oom-3852cb7a9012f8d9f2f3c21ad599c97b1caee477

riptl avatar Aug 01 '22 12:08 riptl

Fixed OOM fuzz findings by adding limits to section/imp/reloc counts. Will let libFuzzer run for another hour or two

riptl avatar Aug 01 '22 12:08 riptl

This pull request introduces 1 alert when merging 790e67f732e116d533b020c3dec1c375d4b3cf69 into a86c2a1aaad65a4a8c848af0a892e67b715eef51 - view on LGTM.com

new alerts:

  • 1 for Unsigned comparison to zero

lgtm-com[bot] avatar Aug 01 '22 13:08 lgtm-com[bot]

This pull request introduces 1 alert when merging 238bd3cb7a61ca0ba4f6f444290dbae9aebf2837 into 2913f019f93bce04a21f9b29f3d0e98d7d51a767 - view on LGTM.com

new alerts:

  • 1 for Unsigned comparison to zero

lgtm-com[bot] avatar Aug 01 '22 16:08 lgtm-com[bot]

make it grin and ill merge

trufae avatar Aug 07 '22 14:08 trufae

ping

trufae avatar Aug 17 '22 22:08 trufae

Tired of waiting, i just fixed the crash and merged the thing. thanks!!

trufae avatar Aug 19 '22 11:08 trufae

Apologies for the wait 😢 Will try to make it up by addressing some backlogged tickets

riptl avatar Aug 19 '22 12:08 riptl

Np :D thanks for the contrib! It was just a tiny thing to get it in. I know its tedious to keep up with all the prs. So its ok for me to take over them

trufae avatar Aug 20 '22 08:08 trufae