MFGLib
MFGLib copied to clipboard
Improve printouts
A few small things to improve the printouts:
- Here we seem to miss a
=sign: https://github.com/radar-research-lab/MFGLib/blob/main/mfglib/alg/utils.py#L43, i.e., should beprint(f"\tA={env_instance.A}")? - Here let's print out all hyperparams of MF-OMO for clarity https://github.com/radar-research-lab/MFGLib/blob/main/mfglib/alg/mf_omo.py#L270. We have printed most of them but missed something like
hat_init, etc. - Right now we have always capped to only 5 digits after the decimal points in the printouts. Also the iter
nseem to be capped to 6 digits. Let's make this dynamic, namely when users max iter and target tolerances are lower, we increase the number of digits shown. Otherwise can lead to confusing all zero expl, etc.
Last but not least, I vaguely remember there is a very rare corner case where if the algorithm converges in iter 0 (with expl 0?) then it somehow crashes or returns NaN but maybe this has already been fixed before we release the v0.1.0 and I'm not seeing it anymore recently but just want to check if you are seeing this again at all or remember whether it's fixed. Thanks!