radar icon indicating copy to clipboard operation
radar copied to clipboard

Published 20 hours ago • verified publisher icon radar-parlamentar

#390: Refatorando importadores CONV

Open hpe95 opened this issue 6 years ago • 2 comments

Resolve #390

hpe95 avatar May 12 '18 21:05 hpe95

Pull Request Test Coverage Report for Build 983

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 145 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-3.3%) to 78.705%
Files with Coverage Reduction New Missed Lines %
modelagem/models.py 2 96.03%
importadores/conv.py 4 95.76%
analises/tests/tests_analise.py 38 75.32%
modelagem/tests/tests_utils.py 39 80.6%
analises/analise.py 62 69.94%
<!-- Total: 145
Totals Coverage Status
Change from base Build 978: -3.3%
Covered Lines: 3696
Relevant Lines: 4696
💛 - Coveralls

coveralls avatar May 12 '18 21:05 coveralls

Aliás, pensando melhor aqui..... esses dados do "_votacoes_param" poderiam ficar num arquivo externo (csv ou json) que é lido nesse código que vocês fizeram, ao invés de ficar "hard-coded" dentro do módulo. (vejam, o codeclimate reclamou das duplicações, e faz sentido, "dados" não devem ficar no source dessa forma. ;)

diraol avatar May 14 '18 02:05 diraol