spark-operator icon indicating copy to clipboard operation
spark-operator copied to clipboard

Add missing executor core limit flag to app deployer

Open sinabakh opened this issue 5 years ago • 4 comments

Add missing spark.kubernetes.executor.limit.cores flag to KubernetesAppDeployer.java.

Related Issue

Fix #255

Types of changes

:bug: Bug fix (non-breaking change which fixes an issue)

sinabakh avatar Oct 10 '19 20:10 sinabakh

this looks reasonable to me, i have not tested it yet though.

elmiko avatar Oct 10 '19 20:10 elmiko

sorry for the late response, the change looks ok. However, travis CI has troubles https://travis-ci.org/radanalyticsio/spark-operator/jobs/596296891#L3102

Could you please try to decrease the number from 400 to 200 here https://github.com/radanalyticsio/spark-operator/blob/master/examples/app.yaml#L16 And let the Travis run the tests?

jkremser avatar Jan 25 '20 16:01 jkremser

I did as you mentioned but I got no clue why tests fail.

sinabakh avatar Jan 25 '20 18:01 sinabakh

thanks, I am trying some different numbers to make travis happy, I will let you know

jkremser avatar Jan 25 '20 20:01 jkremser