web-server icon indicating copy to clipboard operation
web-server copied to clipboard

Published 20 hours ago • verified publisher icon racket

add code to parse content-disposition headers per RFC6266

Open jbclements opened this issue 9 years ago • 3 comments

Okay, that was a bit more unpleasant than expected. Lots of RFC-reading involved, and implementation of a teeny tiny parser combinator framework.

Also, what's our policy on unit tests? This pull request has a bunch of them.

jbclements avatar Sep 16 '16 23:09 jbclements

I'm very happy that you did it and that it works. I'm very anxious because of the big change and yet-another-parser library. There is a test suite, but I think it might be wise to solicit some tests from users of different browsers. I'm not trying to be a pain but I'm just trying to be conservative in this way.

jeapostrophe avatar Sep 18 '16 15:09 jeapostrophe

I totally agree... I know plenty of Mozilians, let me see what I can do.

jbclements avatar Sep 18 '16 18:09 jbclements

We've been sitting on this for a long time. Any updates on the testing worry?

jeapostrophe avatar Mar 15 '17 14:03 jeapostrophe