racket icon indicating copy to clipboard operation
racket copied to clipboard

Improve the error message of bytes-append* and fix bytes-join

Open Antigen-1 opened this issue 1 year ago • 1 comments

Checklist
  • [x] Bugfix
  • [x] Feature
  • [x] tests included
  • [x] documentation

Description of change

  1. Check the arguments of bytes-append*.
  2. It would be better if bytes-join always returns a newly allocated mutable byte string, just like bytes-append.

Antigen-1 avatar Oct 19 '24 03:10 Antigen-1

I don't quite understand why all the other tests passed except for buildtest-win(3m).

Antigen-1 avatar Oct 21 '24 13:10 Antigen-1

Rebasing to racket/racket@3c14248 should include the fix for the foreign test

shhyou avatar Oct 22 '24 05:10 shhyou

Thanks! I've rebased to this commit.

Antigen-1 avatar Oct 22 '24 09:10 Antigen-1

Thanks! I've repaired these.

Antigen-1 avatar Oct 30 '24 04:10 Antigen-1

Thanks!

mflatt avatar Oct 31 '24 12:10 mflatt