racket icon indicating copy to clipboard operation
racket copied to clipboard

Improve error message for set! of imported identifier.

Open samth opened this issue 2 years ago • 3 comments

samth avatar Nov 05 '21 17:11 samth

My hesitation here is whether "another module" is the right phrasing in a top-level context. I don't have a better idea, though, and maybe it's fine.

mflatt avatar Nov 12 '21 13:11 mflatt

I'd use "different" rather than "another". Adding "or surrounding" might help the beginner. (Personally I think of module+ as different from the surrounding one.)

mfelleisen avatar Nov 12 '21 13:11 mfelleisen

I think the best way to deal with that is to put the module where the identifier is defined in the error message, but I couldn't quite follow the error message protocol to add extra pieces.

samth avatar Nov 12 '21 14:11 samth

Is this ready for merging?

sorawee avatar Oct 28 '22 19:10 sorawee

It would really be better to do the thing I mentioned but this would be an improvement.

samth avatar Oct 30 '22 15:10 samth