Text color in the toolbar doesn't change

[bmadone]

Text color in the toolbar doesn't change after macOS dark/light theme changed. Every time when dark/light theme changes I should reload the entire editor, without this it doesn't work properly. For example after dark mode, text in light mode is still light, and doesn't change to dark.

[sorawee]

According to https://github.com/racket/drracket/issues/235#issuecomment-575393730, this is the expected behavior (though obviously not ideal), at least for now.

[rfindler]

I looked into this one specifically, under monterey. It looks like these calls to the os always return the same color (until the app is restarted). If the call changed its answer based on the current settings then we'd see the labels of the buttons change color when the OS's color scheme changed.

I'll transfer this to the gui repo.

[rfindler]

Oh-- an it is specifically the results of get-label-background-color and get-label-foreground-color that do not change but I would have expected them to change.

[rfindler]

Here's the docs on the backgroundColor method that's being called and it makes me wonder if NSColor somehow has to be more dynamic?

[rfindler]

Oops actually this is the method being called.

[rfindler]

This one has been fixed by recent commits, notably https://github.com/racket/gui/commit/70dc167e63188b60758cae46cfc788ea726c0591 and https://github.com/racket/gui/commit/9682a952eb5742a0065ec18195bef7f4db7b7e25 but there is more work for similar stuff that was done recently (and probably more that still needs doing).