drracket icon indicating copy to clipboard operation
drracket copied to clipboard

Automated Resyntax fixes

Open resyntax-ci[bot] opened this issue 1 year ago • 0 comments

This is an automated change generated by Resyntax.

Pass 1

Applied 2 fixes to drracket/drracket/private/syncheck/online-comp.rkt

  • Line 2, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 70, when-expression-in-for-loop-to-when-keyword: Use the #:when keyword instead of when to reduce loop body indentation.

Applied 11 fixes to drracket/drracket/private/syncheck/gui.rkt

  • Line 21, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 385, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2141, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2192, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2356, inline-unnecessary-define: This variable is returned immediately and can be inlined.
  • Line 2464, define-lambda-to-define: The define form supports a shorthand for defining functions.
  • Line 2612, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2640, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2650, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2726, cond-let-to-cond-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2755, flat-contract-migration: flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now.

Applied 1 fix to drracket/drracket/private/syncheck/intf.rkt

  • Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Pass 2

Applied 5 fixes to drracket/drracket/private/syncheck/gui.rkt

  • Line 21, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 387, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2142, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2640, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2650, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.

Pass 3

Applied 1 fix to drracket/drracket/private/syncheck/gui.rkt

  • Line 21, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Summary

Fixed 20 issues in 3 files.

  • Fixed 10 occurrences of let-to-define
  • Fixed 5 occurrences of tidy-require
  • Fixed 1 occurrence of inline-unnecessary-define
  • Fixed 1 occurrence of define-lambda-to-define
  • Fixed 1 occurrence of cond-let-to-cond-define
  • Fixed 1 occurrence of flat-contract-migration
  • Fixed 1 occurrence of when-expression-in-for-loop-to-when-keyword

resyntax-ci[bot] avatar Sep 29 '24 00:09 resyntax-ci[bot]