rack-cache icon indicating copy to clipboard operation
rack-cache copied to clipboard

Error on invalid URIs

Open eraffel-MDSol opened this issue 7 months ago • 0 comments

If a URI is not valid, calling escape here: https://github.com/rack/rack-cache/blob/5261d91b210735a5a79367ff9faebde2dea28788/lib/rack/cache/key.rb#L61

can throw an argument error: https://github.com/ruby/ruby/blob/e5a195edf62fe1bf7146a191da13fa1c4fecbd71/lib/uri/common.rb#L398

Wondering if rack-cache should handle this in some way rather than bubbling it up through the middleware, or if there's a suggestion on how applications should do so

eraffel-MDSol avatar Jul 05 '24 18:07 eraffel-MDSol