rack-attack icon indicating copy to clipboard operation
rack-attack copied to clipboard

Move from proxies to well-defined adapters

Open fatkodima opened this issue 6 years ago • 3 comments

This is a work in progress (failing tests, missing new tests and documentation), but basically is ready for review to verify basic ideas.

To add new adapters, all is needed is inheriting from base class and implementing required methods:

module Rack
  class Attack
    class MyStoreAdapter < StoreAdapter
      ...

Closes #380

fatkodima avatar Oct 12 '19 15:10 fatkodima

Updated this accordingly to master. Added tests. This pr became a little bold. @grzuy Please, review.

fatkodima avatar Oct 25 '19 23:10 fatkodima

This can be considered backwards incompatible change, so it should be considered for v7.x.

grzuy avatar Jan 14 '20 12:01 grzuy

Hey, @grzuy Wdyt on moving this (and my other PRs) forward? Is it time for v7.x?

fatkodima avatar Nov 17 '20 21:11 fatkodima