CHAMI Rachid
CHAMI Rachid
## Description Currently, when running the race tests, we're also adding the `-short` flag. This means that multiple tests get skipped and not checked for races: https://github.com/celestiaorg/celestia-app/blob/6163e271b5128f554a6c19b6eddf415109224833/Makefile#L113 To see the...
We should investigate if it is possible to simplify the BlobstreamX smart contracts architecture so that they're easy to deploy for new chains.
We should write docs on how to deploy BlobstreamX. The docs should include: - how to build new circuits - how to generate the function IDs - how to deploy...
Currently, the blobstream contracts implementations only support proving a set of shares' inclusion to a data root tuple root. This allows building rollups that leverage the [sequence of spans](https://docs.celestia.org/developers/blobstream-rollups#sequence-of-spans) design....
## Overview ## Summary by CodeRabbit - **Documentation** - Enhanced clarity of error handling in the verification process by adding explanatory comments regarding invalid ranges.
The [CI](https://github.com/celestiaorg/nmt/actions/runs/10116549949/job/27979612923) reports the following dead links: ``` [✖] https://github.com/informalsystems/quint/blob/main/tutorials/README.md → Status: 404 [✖] https://github.com/informalsystems/quint/blob/main/doc/quint-cheatsheet.pdf → Status: 404 [✖] https://github.com/informalsystems/quint/blob/main/doc/builtin.md → Status: 404 ```
It's not clear here how the start and end could reference an inner node. Shouldn't it be leaves? I would just say `[start, end)` as it's more succinct. _Originally posted...
Is this func `nextSubtreeSize` unit tested? if not, I'd suggest adding unit tests for it in order to ensure its behaviour is aligned with what it is intended for. _Originally...
Looks correct to me, too. Would still be good to closely look into the case `if end-start == 1` and why both related code blocks are equivalent in all (edge)...
After working on https://github.com/celestiaorg/nmt/issues/256, which only supports proving the inner nodes of an ideal tree. We could extend the work to be general purpose and allow proving the inner nodes...