CHAMI Rachid
CHAMI Rachid
lgtm. given the importance of this lib I think it would be worth setting up a fuzzer. _Originally posted by @evan-forbes in https://github.com/celestiaorg/blobstream-contracts/pull/253#pullrequestreview-1715339368_
can you disable solidity version check for slither then? _Originally posted by @adlerjohn in https://github.com/celestiaorg/blobstream-contracts/pull/246#discussion_r1375990570_
The contracts dir seems to be necessary to be passed to the gen script: https://github.com/celestiaorg/quantum-gravity-bridge/blob/ddcb943075c30dfff42380739c00d605488b4dde/Makefile#L18 We could investigate that and remove it if that's the case.
utack lol @ js  should we include any instrustions on how to use the deploy script? _Originally posted by @evan-forbes in https://github.com/celestiaorg/quantum-gravity-bridge/pull/214#pullrequestreview-1652526363_
It would be nice if this invariant was documented in the code. _Originally posted by @adlerjohn in https://github.com/celestiaorg/quantum-gravity-bridge/issues/201#issuecomment-1742149502_
## Context This PR https://github.com/celestiaorg/quantum-gravity-bridge/pull/177 implements the UUPS pattern in the QGB smart contract. This changes how the QGB contract will be deployed from now on. Previously, we were using...
utACK, will trust it's tested. The script might fail is the filename has spaces, but you can fix that in a follow-up issue. _Originally posted by @adlerjohn in https://github.com/celestiaorg/quantum-gravity-bridge/pull/139#pullrequestreview-1358134251_
Remove package-lock.json for the project to build successfully using different node versions.
As of https://github.com/celestiaorg/cosmos-sdk/pull/137#discussion_r868045921, we're creating a new Ethereum address using the hex representation of the simulated validator account address. This is currently used as a hack to make the tests...
As discussed under: https://github.com/celestiaorg/cosmos-sdk/pull/112. The validator queries featuring the newly added fields are slow. And, according to https://github.com/celestiaorg/celestia-app/issues/369, we can improve them. These improvements should also be done on the...