CHAMI Rachid
CHAMI Rachid
I see, then I'd defer it to you to whether add further checks on `StarRow` and `EndRow` or not. However, I think it is still a valid check (and orthogonal...
Similar to https://github.com/celestiaorg/celestia-app/issues/3734, we have a duplicate of NMT proof between the nmt library and here: NMT: https://github.com/celestiaorg/nmt/blob/main/pb/proof.proto core: https://github.com/celestiaorg/celestia-core/blob/dae3ca9d106c9b27dc192202e052ee0b234f645d/proto/tendermint/types/types.proto#L231-L251 It would be better if we have the proof only...
Closes https://github.com/celestiaorg/celestia-node/issues/3516 and https://github.com/celestiaorg/celestia-node/issues/3582 Note: added couple notes for reviewers concerning the error handling
This PR is created for now just to agree on the existing changes and whether we need to make more changes.
tracing: Ok status should be set once on success. Currently, it's written always by default, while error cases do not overwrite it, so error op may show as success. _Originally...
As of https://github.com/celestiaorg/celestia-node/pull/3610, we query the EDS everytime when getting the proof for a blob. This might lead to degraded performance. We can improve on only using that type of...
We will also add another method that will verify this proof but using the subtree roots _Originally posted by @rach-id in https://github.com/celestiaorg/celestia-node/pull/3610#discussion_r1698751941_
After merging the https://github.com/celestiaorg/celestia-node/pull/3470, we now have all the endpoints needed in blobstream in Celestia-node: - `ProveShares`: which proves that a set of shares, defined by a range, are included...
The comment Rene referred to is about combining this with `GetProof`. The `GetProof` is originally intended to give blob commitment proof, instead of namespace proof, which is a bug. The...
I'm good with merging this now and handling some testApp tech debt later this week if we do, let's just create issue for - being able to query info and...