composer icon indicating copy to clipboard operation
composer copied to clipboard

build(electron): Bump Electron to v2

Open yangchoo opened this issue 4 years ago • 4 comments

This addresses the Harfbuzz version too old (1.4.2) error by bumping the underlying electron dependency to the next major version, v2.

Fixed the underyling calls to setZoomLevelLimits with setVisualZoomLevelLimits.

See https://www.electronjs.org/docs/breaking-changes#webcontents

yangchoo avatar Jul 06 '20 06:07 yangchoo

Hi there, figured I'll push this PR out since I've gotten it to work on my system with this patch.

I've ran the tests locally, and it seems to be working fine.

yangchoo avatar Jul 06 '20 06:07 yangchoo

fwiw, Github actions do not work for forked repos (see https://github.community/t/github-workflow-not-running-from-pull-request-from-forked-repository/16379/47)

I'm happy to help contribute to shift the testing platform to another open-source vendor such as Travis where this functionality exists.

Otherwise, if I could be added to some developer group for pushing to this repo, that'll work as well.

yangchoo avatar Jul 06 '20 06:07 yangchoo

Hello @yangchoo , thank you for making this PR! I will go over it within the week.

ghost avatar Jul 06 '20 13:07 ghost

To build, I had to extend package.json, adding "rwlock": "^5.0.0".

sjaenick avatar Aug 14 '20 14:08 sjaenick