rabbitmq-dotnet-client

rabbitmq-dotnet-client copied to clipboard

- [ ] Check out @bording's project for ideas: * https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/843#issuecomment-632742124 * https://github.com/bording/angora - [ ] Check out @mgravell's projects for ideas: * https://github.com/mgravell/Pipelines.Sockets.Unofficial * https://github.com/StackExchange/StackExchange.Redis - [ ] Consider...

lukebakken

Re-evaluate supported .NET products / C# language version

18

Version 7 of this client supports `netstandard2.0`, which prevents the use of features like [`MemoryPool`](https://learn.microsoft.com/en-us/dotnet/api/system.buffers.memorypool-1?view=net-8.0&viewFallbackFrom=netstandard-2.0). Before shipping version 8, supported frameworks and C# language version should be re-evaluated. Discussion: https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1347#discussion_r1398208131

lukebakken

System.NotSupportedException. Pipelining of requests forbidden after timeout

5

### Describe the bug Hi, If a timeout is produced when trying to declare a queue using the method `QueueDeclare`, following attempts to define a queue using the same `IModel`...

pabermod

Only throw `RabbitMQ.Client`-specific exceptions.

3

### Describe the bug From [Using Standard Exception Types](https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/using-standard-exception-types): > ❌ DO NOT throw [System.Exception](https://learn.microsoft.com/en-us/dotnet/api/system.exception) or [System.SystemException](https://learn.microsoft.com/en-us/dotnet/api/system.systemexception). RabbitMQ code should return RabbitMQ exceptions. If there was another exception causing the...

paulomorgado

Investigate how other .NET client libraries deal with data from applications

2

Reference: https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1445 In that PR, `BasicPublishAsync` is modified to conditionally copy data from the client application. @paulomorgado then followed up with [this comment](https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1445#issuecomment-1858120431). Someone should take a look at libraries...

lukebakken

Back-port the following to the `6.x` branch: * https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1393 * https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/1369

lukebakken

Synchronous operations like CreateModel block their thread waiting for a response to an async Write that they could be blocking.

15

### Describe the bug CreateModel writes to the async write channel in the SocketFrameHandler, then blocks waiting for a response. If you queue up enough of these operations it uses...

michac

Do not create exceptions just for logging

1

### Describe the bug Some exceptions are being created just for logging [here](https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/client/impl/Connection.Receive.cs#L150) and [here](https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/client/impl/Connection.Receive.cs#L155) ### Reproduction steps Just log the error. No need for an exception. But, if it's...

paulomorgado

Related discussions: * https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1347#discussion_r1398218698 * https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1426#discussion_r1400909169 * https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1426#discussion_r1400911052

lukebakken

Support cancellation

2

Reference: [comment](https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1347#discussion_r1396392526) @danielmarbach points out that the async API should support cancellation.

lukebakken