chef-cookbook icon indicating copy to clipboard operation
chef-cookbook copied to clipboard

logrotate_app works only for upstart

Open vladzu opened this issue 4 years ago • 4 comments

Why logrotate is configured only for upstart ?

if node['rabbitmq']['job_control'] == 'upstart' && node['rabbitmq']['manage_service'] ... logrotate_app 'rabbitmq-server' do path node['rabbitmq']['logrotate']['path'] enable node['rabbitmq']['logrotate']['enable'] rotate node['rabbitmq']['logrotate']['rotate'] frequency node['rabbitmq']['logrotate']['frequency'] options node['rabbitmq']['logrotate']['options'] sharedscripts node['rabbitmq']['logrotate']['sharedscripts'] postrotate node['rabbitmq']['logrotate']['postrotate'] end

why this is like that ? and why not to use it for systemd OS's?

vladzu avatar Mar 13 '20 12:03 vladzu

Because this cookbook predates systemd or at least its widespread use. Contributions are welcome, this is open source software after all.

On Fri, 13 Mar 2020 at 15:29, Vladimir Zulin-Tarelkin < [email protected]> wrote:

Why logrotate is configured only for upstart ?

if node['rabbitmq']['job_control'] == 'upstart' && node['rabbitmq']['manage_service'] ... logrotate_app 'rabbitmq-server' do path node['rabbitmq']['logrotate']['path'] enable node['rabbitmq']['logrotate']['enable'] rotate node['rabbitmq']['logrotate']['rotate'] frequency node['rabbitmq']['logrotate']['frequency'] options node['rabbitmq']['logrotate']['options'] sharedscripts node['rabbitmq']['logrotate']['sharedscripts'] postrotate node['rabbitmq']['logrotate']['postrotate'] end

why this is like that ? and why not to use it for systemd OS's?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rabbitmq/chef-cookbook/issues/550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAIQTPWHHKPH3CD3SK5KDRHIRLHANCNFSM4LHBQDOQ .

-- Staff Software Engineer, Pivotal/RabbitMQ

michaelklishin avatar Mar 14 '20 06:03 michaelklishin

@michaelklishin What do you think to removing all of the logrotate stuff altogether? IMO a rabbitmq cookbook should install and configure rabbitmq and nothing else.

fozboz avatar Dec 17 '22 18:12 fozboz

@fozboz makes sense to me. Feel free to open a PR

lukebakken avatar Dec 18 '22 00:12 lukebakken

I agree.

michaelklishin avatar Dec 19 '22 01:12 michaelklishin