compose-destinations icon indicating copy to clipboard operation
compose-destinations copied to clipboard

Not correct docs and error log about BottomSheet Style

Open MishkaV opened this issue 2 years ago • 2 comments

When adding a BottomSheet Style, the documentation gives incorrect instructions for implementing this style:

  • Destination style I didn't find DestinationStyle.BottomSheet, but after research I found DestinationStyleBottomSheet which provide this possibilities, therefore we should use:
@Destination(style = DestinationStyleBottomSheet::class)
@Composable
fun ColumnScope.SomeBottomSheetScreen() { /*...*/ }

  • Initialization of navController:
val navController = rememberAnimatedNavController()

With using new compose navigation with supporting animation, we should use this:

import androidx.navigation.compose.rememberNavController

val navController = rememberNavController()
  • Internal error logs: In code we have fallback, if we didn't find suitable DestinationStyle with old info about DestinationStyle.BottomSheet and DestinationStyleBottomSheet

So, thank you in advance for your attention, can support with fixing)

MishkaV avatar Nov 23 '23 13:11 MishkaV

It looks like this documentation is very outdated. Here it tells me to use navController.navigateTo() method, but apparently it's deprecated image

Besides, on the setup page, it doesn't include 1.9.x releases, and lists 1.8.x-beta as the newest version

rafal06 avatar Nov 25 '23 12:11 rafal06

There's already an issue open for the outdated docs https://github.com/raamcosta/compose-destinations/issues/449

rafal06 avatar Nov 25 '23 12:11 rafal06

Closing this one as docs are being updated now for v2. Also some of these issues were fixed on v1 in the mean time.

raamcosta avatar Mar 12 '24 00:03 raamcosta