compose-destinations icon indicating copy to clipboard operation
compose-destinations copied to clipboard

Implement hierarchy helper functions

Open MaxMichel2 opened this issue 3 years ago • 3 comments

Adds the #186 enhancement

MaxMichel2 avatar Jul 22 '22 16:07 MaxMichel2

Hello @raamcosta, not sure how merging PR's work for you so sorry for tagging you for no reason if it's unnecessary..

This PR feels up to standard for me in terms of its contents, feel free to approve or reject it! There's probably a more elegant way of doing the same thing but hey, I'm learning the internals of your library (which I find really interesting by the way!) :)

Thanks in advance

MaxMichel2 avatar Jul 25 '22 14:07 MaxMichel2

Hello @raamcosta, not sure how merging PR's work for you so sorry for tagging you for no reason if it's unnecessary..

This PR feels up to standard for me in terms of its contents, feel free to approve or reject it! There's probably a more elegant way of doing the same thing but hey, I'm learning the internals of your library (which I find really interesting by the way!) :)

Thanks in advance

Of course! Thank you so much for this PR 🙏 And sorry I haven’t given any feedback yet. Reason is I’ve been quite busy lately so I’ve given priority to new issues and fixes I needed to do. I will eventually check this and provide all the feedback 🙂

Thank you also for checking the code and liking it. There is quite a bit of messy parts in there that I wish I had time to clean up 😅

raamcosta avatar Jul 25 '22 16:07 raamcosta

@MaxMichel2 sorry I still haven’t merged this, it is not forgotten. The thing now is that I am doing quite a few changes which can probably bring new approaches to do this, so I’d rather wait for that and then recheck this PR. Thank you again 🙏

raamcosta avatar Aug 10 '22 22:08 raamcosta