Raam Rosh-Hai

@adriancole I wanted to but I think the difference only happens after passing through the whole thrift encoding/decoding inside zipkin collector on the zipkin side. process and I couldn't find...

@adriancole The test does cover it and I wrote a test a different test before sending the PR but it wouldn't fail. I'm pretty sure the problem lies in https://github.com/openzipkin/zipkin/blob/master/zipkin/src/main/java/zipkin/internal/ThriftCodec.java#L244...

@adriancole I totally agree, I just wanted to make sure I am testing for the right things.

Thank you for the suggestion, @adriancole. I've added the test but I still can't make it fail when changing encoding type. In the zipkin frontend this change definitely fixes the...

I Hope it's just the beginning 👯

Yes I am having the same issue, I do not want jacoco to run the tests only report on coverage.

In case someone is stuck with typescript error: like ` Type '{ labels: string[]; datasets: ({ data: number[]; label: string; backgroundColor: string; } | { label: string; data: number[]; type:...

Would love a scala page for akka-http. I'm currently doing ``` class Routes(sys: ActorSystem) extends BaseTracingDirectives{ override def trace: TracingExtensionImpl = TracingExtension(sys) //Routes go here } ``` I am not...

@tonypizzicato my route looks like this: ``` val tracedPlaces = (am: ActorMaterializer) => path("tplace") { get { implicit val aq = am tracedHandleWith("place")(processPlace) } } ``` make sure you return...

@captainju you can use this https://github.com/FindHotel/akka-stream-trace