pow-app icon indicating copy to clipboard operation
pow-app copied to clipboard

Remove newsletter prompt, add "save to home screen" prompt

Open raae opened this issue 5 years ago β€’ 10 comments

Do this when #148 is done.

raae avatar Sep 10 '20 05:09 raae

It seems that the newsletter prompt is gone somehow anyway.

After the welcome prompt, there should be prompt letting people know they should save to home screen for a more app like experience. Maybe even a link to a support page on this, with a video or something.

All the code for this can be found in onboarding/Welcome, start by deleting newsletter stuff. Then replicate the welcomeCompleted code.

This is the welcome prompt I am talking about:

CleanShot 2020-10-09 at 07 13 36@2x

raae avatar Oct 09 '20 05:10 raae

Have you seen this one @olavea?

raae avatar Oct 10 '20 08:10 raae

All the code for this can be found in

  • [x] Onboarding/Welcome,
  • [x] start by deleting newsletter stuff. Then
  • [x] replicate the welcomeCompleted code.

Ideas: "You should save to home screen for a more app like experience." Text from Glideapps? Maybe even a link to a support page on this, with a video or something.

Questions:

olavea avatar Oct 15 '20 06:10 olavea

Look good so far.

I think there is a possibility to get a link that does it for us, not having to send them to a "how to article".

https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Add_to_home_screen https://web.dev/customize-install/

raae avatar Nov 01 '20 06:11 raae

  • [ ] I have looked at my code.
  • [x] I will "pull" new master
  • [x] I will make a new branch
  • [ ] I have read https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Add_to_home_screen
  • [ ] and https://web.dev/customize-install/
  • [ ] Next step is _ _ _ _

@raae

olavea avatar Nov 10 '20 10:11 olavea

Question 1

Why is this old alert still here?

It should say "Add POW! To Your Home Screen πŸ˜ΊπŸ‘"

POW-old_alert-303 1

olavea avatar Dec 16 '20 09:12 olavea

Wrong page. The alert us the one that comes under today on the timeline page.

raae avatar Dec 16 '20 13:12 raae

I figured out why, you are reading the welcomeCompleted value into your addToHomeScreen variable. See pull request for inline comments.

raae avatar Dec 21 '20 06:12 raae

I'll keep working on this, I have some ideas 😸 πŸ‘ POW-1 Go away! 2 Empty? 3 What to do?-316

olavea avatar Jan 03 '21 07:01 olavea

I gave you some inline comments in the pull request, I will also link this issue to the PR you do the work in. See below.

raae avatar Jan 04 '21 10:01 raae