RAReorderableLayout icon indicating copy to clipboard operation
RAReorderableLayout copied to clipboard
verified publisher icon ra1028

Fix Objective-C compatebility

Open ikorich opened this issue 9 years ago • 5 comments

RAReorderableLayoutDataSource and RAReorderableLayoutDelegate are hidden for Objective-C. need add

@objc

to protocols

ikorich avatar Oct 29 '16 01:10 ikorich

@iKorich Could you remove default behavior of RAReorderableLayoutDelegate/RAReorderableLayoutDatasource from these extensions?

ra1028 avatar Nov 09 '16 02:11 ra1028

Hi @ra1028

I don't want remove it, because thats not for obj-c fix,

Also I can fix some issues, just mark it for me

ikorich avatar Nov 09 '16 14:11 ikorich

But, it's not require in @objc optional function.

ra1028 avatar Nov 15 '16 16:11 ra1028

@ra1028 also any chance of getting this PR merged. It's needed for ObjC compatibility.

ricsantos avatar Apr 16 '18 02:04 ricsantos

After further investigation, I'm not convinced that these protocol methods should be marked as optional.

From my testing in an ObjC project using this pod as a dependency, with the Swift 3.2 compiler, if the methods are marked optional then the default implementation provided by the protocol extensions is called instead of the ObjC implementation.

ricsantos avatar Apr 16 '18 04:04 ricsantos