Former icon indicating copy to clipboard operation
Former copied to clipboard

InlinePickerRowFormer resets "selectedRow" back to index 0

Open Daxito opened this issue 6 years ago • 4 comments

Hi, Line 79 of this file Former/Former/RowFormers/InlinePickerRowFormer.swift causes not being able to set selectedRow to different index: }.configure{ $0.pickerItems = SOME_COLLECTION_WITH_100_ITEMS $0.selectedRow = 2 //<--- This is always overwritten by line 79 back to 0 }

Thanks

Daxito avatar May 12 '18 01:05 Daxito

We can have a

selectedRow = 0 only when selectedRow >= pickerItems.count

IMO that would be a better approach for the fix that you have employed for index out of range

croyneaus4u avatar May 14 '18 11:05 croyneaus4u

I will look into this and get back to you shortly

ZacharyKhan avatar Jun 19 '19 18:06 ZacharyKhan

any news on this? same issue here. and thanks a lot for this nice piece of software!

benwalch avatar Dec 01 '19 18:12 benwalch

@benwalch Do you found a way to fix it?

phr85 avatar Dec 19 '19 00:12 phr85