eurostat icon indicating copy to clipboard operation
eurostat copied to clipboard

API version

Open antagomir opened this issue 5 years ago • 1 comments

The get_eurostat_json.R function is now updated to use API v2.1. However its structure has changed somewhat from v1.1, and we have not thoroughly tested that the outputs are correct. No mistakes have been spotted but the output should be checked systematically against the eurostat website using various queries (or automated check of all output) in order to verify correct performance.

antagomir avatar Feb 07 '20 21:02 antagomir

@antaldaniel you mentioned having some automated benchmarks to eurostat data; to what extent it might apply here as a validation; and is the code available?

antagomir avatar Feb 11 '20 15:02 antagomir

Fixed partly in #252, #253, #254 and commit 4bf171d to v4-dev branch. The structure of the output is different at least in the way that there is now a new freq column that gives information on the update frequency of the data ("A" for annual, "S" for semi-annual / semester, "Q" for quarterly, and so on) and that "time" column is now called TIME_PERIOD. I did not think preserving the old time column name or removing the freq column was worth the effort, as the world moves onwards and the changes to end-users' scripts shouldn't be too complicated to make.

When it comes to systematic checks, the package tests have been adjusted accordingly. In my view this issue can be closed, maybe if we want other kinds of checks another issue can be opened?

pitkant avatar Jun 26 '23 13:06 pitkant

The issue described in this issue seems to refer to API calls that are deprecated and not applicable to the current situation. If anyone experiences similar problems exist please open a new issue. Closed with the CRAN release of package version 4.0.0.

pitkant avatar Dec 20 '23 08:12 pitkant