clean-uninstall icon indicating copy to clipboard operation
clean-uninstall copied to clipboard

Version 0.2.0 still tries to remove preferences on "Disable"

Open graciecat opened this issue 7 years ago • 3 comments

Your release notes at AMO states that version 0.2.0 will not offer cleaning prefs on extension disable event (FF version > 52.0). However, in FF 54 in Ubuntu 14.04.5, I see the dialog asking me to delete preferences when I merely disable rather than remove an extension.

graciecat avatar Aug 20 '17 07:08 graciecat

Well, seems like I meant greater than 54.0! https://github.com/rNeomy/clean-uninstall/blob/914d3f792afd0e63c43508e9ad9ae02bfb7abeb8/src/background.js#L97

I am fixing the change log

rNeomy avatar Aug 22 '17 13:08 rNeomy

Oh. I was hoping you'd fix the extension so the dialog wouldn't erroneously pop up in Firefox 52 ESR. :-)

graciecat avatar Aug 26 '17 11:08 graciecat

Well, It is not possible. Before FF54, when an extension is removed or being disabled, a single event is fired.

rNeomy avatar Aug 30 '17 11:08 rNeomy