auto-tab-discard icon indicating copy to clipboard operation
auto-tab-discard copied to clipboard

Tab's icon lose

Open Traine9 opened this issue 6 years ago • 13 comments

Version 0.1.8 FF Quantum 59.0b14 When reopen FF some tabs lose their icons and needs to load discarded tab to load icon.

Traine9 avatar Mar 02 '18 22:03 Traine9

Same.

MrRobot12 avatar Mar 04 '18 10:03 MrRobot12

https://addons.mozilla.org/firefox/addon/tab-unloader-we/ There's the same bug. So, I think this is a bug of new Firefox API.

perdolka avatar Mar 04 '18 23:03 perdolka

I am seeing this quite a bit right now, so I am kind of glad other people are at least seeing it as well. I've tried several things including clearing caches, deleting favicons.sqlite, ensuring a page fully loads and then discards with the favicon intact.

At the end of the day, even with all of this there are some percentage of tabs that after the browser is restarted, come up with the default favicon. This can obviously be fixed by actively loading the tab. The problem is that people with a lot of tabs use the favicon to help quickly identify the tabs they are looking for.

I have found that it is sometime possible to copy the tab (middle-click "reload") into a new tab and that tab might not have any issues. However, it is clear to me that some % of tabs run into this problem and it seems to be related to the Firefox session handler.

I also tried doing a search on https://bugzilla.mozilla.org/ for favicon and did find a fair number of items, but none that seemed to be for Firefox related to FF59+ with restarting the browser.

irvinm avatar Mar 22 '18 17:03 irvinm

FYI, I am not sure if these are directly related or not, but I have contributed some information towards the unconfirmed bug https://bugzilla.mozilla.org/show_bug.cgi?id=1427822. There are 171 votes for this issue, so I am a little surprised it is unconfirmed and a P3 at this point.

irvinm avatar Mar 26 '18 15:03 irvinm

This need's a work-around, implemented by the Addon manually opening an initial blank page, setting the Saved Icon and then Terminating the Tab

AtomicBones avatar Apr 14 '18 04:04 AtomicBones

It looks like this issue might get progress shortly although I am not convinced it will be completely fixed. I have been tracking several of the related issues being tracked for Firefox and many have been marked as resolved for FF63.

  • FF63: https://bugzilla.mozilla.org/show_bug.cgi?id=1453751 (Favicons should only be loaded once)
  • FF62: https://bugzilla.mozilla.org/show_bug.cgi?id=1422588 (a tab discarded immediately after creation gains a corrupted session state.)
  • None: https://bugzilla.mozilla.org/show_bug.cgi?id=1450382 (loading discarded/pending tabs removes the favicon) [Thought to be related to 1453751, but still actively being investigated] -- Dup: https://bugzilla.mozilla.org/show_bug.cgi?id=1451799 (Tabs that were discarded prior to quitting do not have icons when later restoring the session) -- Dup: https://bugzilla.mozilla.org/show_bug.cgi?id=1453432 (Discarding a tab clears its favicon) -- Dup: https://bugzilla.mozilla.org/show_bug.cgi?id=1451799 (Tabs that were discarded prior to quitting do not have icons when later restoring the session)
  • None: https://bugzilla.mozilla.org/show_bug.cgi?id=1427822 (when discarding a tab, the favicon will sometimes not restore)

I would say that if anyone can still reproduce the situation in FF63 now, they should contribute that information to https://bugzilla.mozilla.org/show_bug.cgi?id=1450382 to prove\disprove if this will be fixed when Firefox 63 is released on October 22, 2018.

irvinm avatar Jul 10 '18 21:07 irvinm

@irvinm I tested on ff63 and it still looses the favicon. I did not see any of then saying that it's fixed for ff63. Maybe it's planned to be fixed by then but is not at the moment.

rayman89 avatar Aug 20 '18 13:08 rayman89

This is a huge issue for pinned tabs since the favicon is pretty well all you get to see which tab is which. I'm looking forward to a fix. :-)

foxpup avatar Sep 07 '18 17:09 foxpup

@rayman89

@irvinm I tested on ff63 and it still looses the favicon. I did not see any of then saying that it's fixed for ff63. Maybe it's planned to be fixed by then but is not at the moment.

This problem with favicons was not fixed yet: https://bugzilla.mozilla.org/show_bug.cgi?id=1475240

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1462813 https://bugzilla.mozilla.org/show_bug.cgi?id=1427928 https://www.reddit.com/r/firefox/comments/7m8nvx/can_session_manager_tab_session_manager_coexist/drslt43/

RobertAb1 avatar Apr 19 '19 18:04 RobertAb1

it's been solved since 65 or 66 afik.

rayman89 avatar Apr 27 '19 01:04 rayman89

@rayman89 We need to be careful here. There are 2 different bugs: Bug 1475240 (allow setting favicon when creating discarded tabs) Bug 1450382 (loading discarded/pending tabs removes the favicon) Do you think than both bugs were fixed or just Bug 1450382.

RobertAb1 avatar Apr 28 '19 22:04 RobertAb1

This issue reported that the tab looses it's icon when suspended this has nothing to do with session restoring by an extension (aka bug 1475240). If you restore a session using firefox built in session restorer you always keep the favicons.

rayman89 avatar Apr 29 '19 20:04 rayman89

@rayman89

I think that there is mix-up here about type of favicon lose related to discarding. We can have favicon loss: (1) when discarding tab (so discarded tab will not have favicon), (2) when discarded tab is opened (discarded tab has favicon, opened/active looses favicon).

.

@rayman89: This issue reported that the tab looses it's icon when suspended this has nothing to do with session restoring by an extension (aka bug 1475240).

The issue you mentioned is related to situation (1) and it is described by Bug 1475240 (allow setting favicon when creating discarded tabs). Also Bug 1475240 is affecting not only session managers, but also other extensions discarding tabs if they are using WebExtension API introduced in Bug 1378647.

.

Issue (2) is related to Bug 1450382 (loading discarded/pending tabs removes the favicon). This is a part of description from Bug 1450382:

Loading an unloaded (discarded, not yet restored) tab (at least in response to closing a tab) removes its favicon (...)

RobertAb1 avatar Apr 29 '19 22:04 RobertAb1