auto-tab-discard icon indicating copy to clipboard operation
auto-tab-discard copied to clipboard

Please keep a Changelog/Release Notes

Open dserodio opened this issue 4 years ago • 17 comments

First of all, thank you for developing this amazing extension, it makes my computer so much more responsive.

My Firefox just opened this URL, which I assume it's a way of telling me that it's been updated from 0.3.5.2 to 0.3.6. But on that page I can't see what changed between these versions, so I came to GitHub, and didn't find a release notes document not any GitHub Releases or git tags.

It would be great if you could keep a Changelog. I use this format for my own projects, but you could also use GitHub Releases feature.

Thanks!

dserodio avatar Jun 25 '20 14:06 dserodio

It is on the page from the URL you put in the Issue. Look at bullet 4

What's new in this version? Please check the Logs section.

https://add0n.com/tab-discard.html#log-container

warthurton avatar Jun 25 '20 15:06 warthurton

Would be nice if it was in the repo as well, but there is a history here: https://addons.mozilla.org/en-CA/firefox/addon/auto-tab-discard/versions/

strigona-worksight avatar Jun 26 '20 16:06 strigona-worksight

@warthurton When navigating to that link, the comment section immediately expands and pushes all of that information way down the page.

I didn't realize this at first, so I assumed section was missing and there were just comments, because expanding comment sections are almost always the last thing on a page.

Inverness avatar Jun 28 '20 17:06 Inverness

That's exactly what happened Inverness. The comment section is usually at the end of a page so I assumed there was no other content on that page.

dserodio avatar Jul 27 '20 14:07 dserodio

I do like a brief summary changes to be visible at a glance at about:addons i.e.

image

That said, I'm equally happy with a link out from about:addons to a log, if the log is suitably clear.

As an example, https://github.com/dessant/search-by-image/issues/104 drew attention to https://github.com/dessant/search-by-image/compare/v3.1.0...v3.4.1 and the developer chose to link out:

image

– to a more user-friendly log i.e. https://github.com/dessant/search-by-image/blob/master/CHANGELOG.md#341-2020-11-23

grahamperrin avatar Dec 08 '20 04:12 grahamperrin

Version 0.4.0 was released (and auto-updated), but it's not mentioned in https://github.com/dessant/search-by-image/blob/master/CHANGELOG.md and https://add0n.com/tab-discard.html?version=0.4.0&p=0.3.7&type=update shows "No release note found for current version!"

image

dserodio avatar Feb 03 '21 19:02 dserodio

https://addons.mozilla.org/addon/auto-tab-discard/versions/ shows 0.3.7 (2020-07-18) rising to 0.4.0 yesterday (2021-02-02).

Given https://github.com/rNeomy/auto-tab-discard/commits/master, the change log for 0.4.0 might be viewed as:

  • https://github.com/rNeomy/auto-tab-discard/compare/658babb4bb67448d1dbf960727e693a7ffd4601f...46c01116a65ad00db95caf5447c414c0e8741af7

grahamperrin avatar Feb 03 '21 19:02 grahamperrin

Gentle bump @rNeomy please, can you make it habit to provide release notes? I always like to see notes before deciding whether to allow an update. Thanks.

image

grahamperrin avatar Feb 24 '21 18:02 grahamperrin

https://github.com/rNeomy/auto-tab-discard/issues/205#issuecomment-784780523 🏆

In the meantime, if I understand correctly, for 0.4.00.4.1.1 it's:

  • https://github.com/rNeomy/auto-tab-discard/compare/46c01116a65ad00db95caf5447c414c0e8741af7...a2138f31dd9f63808dd792da83d64ff51cf24410

grahamperrin avatar Feb 25 '21 12:02 grahamperrin

@grahamperrin this is what I get on the FAQs page.

The FAQs page uses AMO's log API. So it might take some time for it to update.

s

rNeomy avatar Feb 28 '21 08:02 rNeomy

AMO's log API.

OK, now I see the underlying issue. I assumed, wrongly, that notes had not been provided to AMO.

They're present, but not translated:

  • https://addons.mozilla.org/en-US/firefox/addon/auto-tab-discard/versions/0.4.1.1/updateinfo/ has notes
  • https://addons.mozilla.org/en-GB/firefox/addon/auto-tab-discard/versions/0.4.1.1/updateinfo/ is empty

– and so, emptiness within Firefox:

image

People with Firefox set to a US locale will probably find notes very quickly at about:addons in Firefox – without the delays that might be associated with add0n.com

grahamperrin avatar Feb 28 '21 17:02 grahamperrin

@grahamperrin so you see the notes on the FAQs page now, right?

rNeomy avatar Mar 01 '21 05:03 rNeomy

https://add0n.com/tab-discard.html#log-container reviewed in Firefox 86.0 release candidate 3 following a cache-free reload:

No release note found for current version!

In a different browser, the notes do appear.

Back to Firefox, there's a workaround to the problem with add0n.com:

  1. about:preferences#general
  2. Choose your preferred language for displaying pages ▶ Choose…
  3. add English (United States) [en-us], if it's not already listed
  4. move the non-preferred language to the top of the list
  5. OK
  6. revisit https://add0n.com/tab-discard.html#log-container
  7. perform a simple reload
  8. revisit about:preferences#general
  9. end the United States pretence
  10. OK

– after which a load or reload of https://add0n.com/tab-discard.html#log-container will revert to presenting false information :-(

Step (4) above:

image

grahamperrin avatar Mar 01 '21 09:03 grahamperrin

That's wired! Based on the network log, the FAQs page has a script to fetch https://addons.mozilla.org/api/v3/addons/addon/%7Bc2c003ee-bd69-42a2-b0e9-6f34222cb046%7D/versions/ to get the log info. This API is not localized but keeps the changelogs in all languages. There is a script on the page to display the first available localized log. So I am not sure how you get the No release note found for current version! message

rNeomy avatar Mar 02 '21 09:03 rNeomy

https://addons.mozilla.org/en-CA/firefox/addon/auto-tab-discard/versions/0.4.8/updateinfo/

grahamperrin avatar Dec 14 '21 03:12 grahamperrin

@grahamperrin I just released 0.4.8 on GitHub

rNeomy avatar Dec 14 '21 04:12 rNeomy