SCRecorder icon indicating copy to clipboard operation
SCRecorder copied to clipboard

snapshotOfLastVideoBuffer was not working

Open GabeRoze opened this issue 8 years ago • 6 comments

CIContext was nil, now its not.

GabeRoze avatar May 17 '16 23:05 GabeRoze

lol small world

mitchellporter avatar May 18 '16 00:05 mitchellporter

hah fancy meeting you here. Ever figure out what was wrong with your AVPlayer?

GabeRoze avatar May 18 '16 00:05 GabeRoze

Not yet, I took a break from it. Had some more people reach out to help, some promising leads. I may just move to paging.

mitchellporter avatar May 18 '16 00:05 mitchellporter

Hey, that's a great fix. Could you please refactor your change on mergeSegmentsUsingPreset so the code is not duplicated? You could make the original implementation figure out the outputUrl and call [self mergeSegmentsUsingPreset:preset atURL:outputUrl completion:completion]

rFlex avatar May 18 '16 13:05 rFlex

Also, it's a small detail but on the header you should add the specifiers to tell if an argument is optional or not. That way it integrates nicely with Swift :). Thank you so much!

rFlex avatar May 18 '16 13:05 rFlex

Quick fix until pull request is open:

    let recorder = SCRecorder.shared()
    let context = SCContext(type: .auto)
    recorder.setValue(context.ciContext, forKeyPath: "_context")

AlexandrGraschenkov avatar Nov 24 '16 12:11 AlexandrGraschenkov