r4ss icon indicating copy to clipboard operation
r4ss copied to clipboard

problems with recruitment plotted by SSplotTimeseries() when recruitment is year after spawning

Open iantaylor-NOAA opened this issue 4 years ago • 0 comments

A sardine model with 2 seasons per year, spawning in season 2 and recruitment in season 1 revealed misalignment between horizontal position of point estimates and uncertainty intervals for multiple plots. I think this is fixed for the plots of spawning output in commit ece55552a6910a9d5e807cea7238a958200c0c84 but the recruitment plot is not yet working correctly.

The section of code below is skipped for multi-season models for reasons that I don't remember. That section should be expanded to work for both single-season and multi-season models that have recruitment in the year following spawning. https://github.com/r4ss/r4ss/blob/311ffb20c1baba3c34b8cb1f2be85d260f669ecb/R/SSplotTimeseries.R#L247-L255

iantaylor-NOAA avatar Feb 23 '21 00:02 iantaylor-NOAA