pip-check-reqs icon indicating copy to clipboard operation
pip-check-reqs copied to clipboard

Item location relative to package, not 'here'

Open theahura opened this issue 2 years ago • 3 comments

Previously, find_extra_reqs would concatenate the package_location with the file_location for a library import. This fails when using a virtualenv, because the package_location and the file_location end up sharing paths. This PR changes the file_location to be relative to the package, so that you get an actual file path.

Fixes #75.

theahura avatar Nov 03 '21 15:11 theahura

Any update on this? It's a pretty low key change, would love to get this merged.

theahura avatar Nov 24 '21 03:11 theahura

I do not have availability right now to work on this.

cc @MrMino .

adamtheturtle avatar Nov 24 '21 12:11 adamtheturtle

Some tests for this would be nice.

I still need to reproduce the original issue to make sure this works.

MrMino avatar Mar 18 '22 12:03 MrMino