pywebview icon indicating copy to clipboard operation
pywebview copied to clipboard

Allow full screen

Open armin567ip opened this issue 1 year ago • 8 comments

Hi, I need a feature request which is allowing full screen. I mean not actual full screen for the app. for websites like youtube when the video is going to be full screen, i want it to be full screen

armin567ip avatar Dec 19 '23 19:12 armin567ip

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 19 '24 02:01 github-actions[bot]

Yeah, this would be a good addition.

r0x0r avatar Jan 19 '24 08:01 r0x0r

Yeah, this would be a good addition.

Bro you totally understand what I'm saying?, and can you please add this feature to Pywebview Asap please, I need it

armin567ip avatar Jan 19 '24 08:01 armin567ip

Yeah, I understand. If you need it asap, you can consider sponsoring this issue.

r0x0r avatar Jan 20 '24 21:01 r0x0r

Yeah, I understand. If you need it asap, you can consider sponsoring this issue.

Ok But how much? And BTW I cam only do payment in crypto because of my country's situation.

armin567ip avatar Jan 21 '24 04:01 armin567ip

Oh it's Paypal, Think I can do that. Is 5 dollars OK bro?

armin567ip avatar Jan 21 '24 14:01 armin567ip

I am sorry, but I live in the country where you can get barely a cup of coffee for 5 euros. The rate for custom work is 80e/h.

If this is prohibitively expensive for you, then consider doing it yourself. I think it can be done fairly easy by listening to fullscreenchange dom event and then calling window.toggle_fullscreen() via js_api.

r0x0r avatar Jan 22 '24 11:01 r0x0r

Bro how much if I donate will you add this?

armin567ip avatar Jan 29 '24 10:01 armin567ip

I gave this a go and it turned out to be not as straightforward as I thought. The JS API hack did not work and each platform must be tackled separately. It seems to be possible though.

If you want to work on this, here are search keywords to get you on the right track wkwebview requestfullscreen, webview2 requestfullscreen, qtwebengine requestfullscreen, gtk webkit requestfullscreen

ChatGTP might be of help too.

r0x0r avatar Feb 26 '24 20:02 r0x0r

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 28 '24 02:03 github-actions[bot]

The message to post on the issue when closing it. If none provided, will not comment when closing an issue.

github-actions[bot] avatar Apr 02 '24 02:04 github-actions[bot]