upload-google-play icon indicating copy to clipboard operation
upload-google-play copied to clipboard

Failed to publish AAB with error

Open hivenet-sathishgadde-osi opened this issue 1 year ago • 44 comments

Describe the bug Am randomly facing the below error: image

Workflow Step Configuration ``

      - name: Publish AAB to Google Play
        uses: r0adkll/upload-google-play@v1
        with:
          serviceAccountJsonPlainText: ${{ secrets.SERVICE_ACCOUNT_JSON }}
          packageName: com.android.demo.preprod
          releaseFiles: ./apps/***/build/outputs/bundle/preprod/***-preprod.aab
          track: ${{ env.RELEASE_TRACK }}
          releaseName: ${{ env.VERSION_CODE }} (${{ env.VERSION_NAME }})
          inAppUpdatePriority: ${{ env.IN_APP_UPDATE_PRIORITY }}

Step Debugging

At the moment, I don't have the debug logs. I'll share them with you once I've collected this information from the workflow.

Experiencing this issue too

Nek-12 avatar Sep 13 '23 18:09 Nek-12

Same here

hexlogic avatar Sep 15 '23 12:09 hexlogic

Same here

joao-albach avatar Sep 15 '23 17:09 joao-albach

By "randomly", do you mean it sometimes fails and sometimes succeeds?

boswelja avatar Sep 15 '23 23:09 boswelja

It's looks like the issue is on Google side. The same error occurs when publishing via fastlane: https://github.com/fastlane/fastlane/issues/21507

aabiryukov avatar Sep 16 '23 10:09 aabiryukov

@r0adkll From the issue shared by @aabiryukov, it seems the fix is to update the android publisher url to "https://androidpublisher.googleapis.com/" in this file: https://github.com/r0adkll/upload-google-play/blob/master/src/edits.ts#L52

willhou avatar Sep 16 '23 13:09 willhou

Interesting, we can give that a go

boswelja avatar Sep 17 '23 01:09 boswelja

@r0adkll From the issue shared by @aabiryukov, it seems the fix is to update the android publisher url to "https://androidpublisher.googleapis.com/" in this file: https://github.com/r0adkll/upload-google-play/blob/master/src/edits.ts#L52

It's worth mentioning Fastlane developers confirmed the URL is not an issue, and all they could do was optimize network calls so it had less chances to happen

boswelja avatar Sep 17 '23 08:09 boswelja

If anyone is interested in testing this, please try using the branch for #190 in your action. Note that this error is random, and a one-shot run is not enough to say whether this has helped

boswelja avatar Sep 17 '23 08:09 boswelja

Changing to attempt-fix-for-random-google-issue I got an error

image

msgivaldo avatar Sep 17 '23 13:09 msgivaldo

Changing to attempt-fix-for-random-google-issue I got an error

image

Thanks for trying it! Does it consistently give that error? If so, we can probably discard the change

boswelja avatar Sep 17 '23 22:09 boswelja

Same "Invalid Credentials" error from the attempt-fix... branch, if you want one more data point.

menssen avatar Sep 18 '23 06:09 menssen

I have the same error just when I'm trying to use whatsNewDirectory, and it works properly when i removed it.

      - name: Publish To Store
        uses: r0adkll/[email protected]
        with:
          serviceAccountJson: android/service_account.json
          packageName: '....'
          releaseFiles: build/app/outputs/bundle/release/app-release.aab
          track: production
          whatsNewDirectory: whatsnew

omar-alshyokh avatar Sep 18 '23 11:09 omar-alshyokh

I've tried v1 tag without whatsNewDirectory and works as expected too

- name: Deploy to Play Store
  id: deploy
  uses: r0adkll/upload-google-play@v1
  with:
    serviceAccountJson: service_account.json
    packageName: dev.givaldo.carspecs
    releaseFiles: android/app/build/outputs/bundle/release/app-release.aab
    mappingFile: android/app/build/outputs/mapping/release/mapping.txt
    track: beta
image

msgivaldo avatar Sep 18 '23 13:09 msgivaldo

I don't think the whatsNewDirectory really affects anything. This is my task

 - name: upload PROD package to Google Play
        uses: r0adkll/upload-google-play@v1
        with:
          serviceAccountJsonPlainText: ${{ secrets.PLAY_CONSOLE_SERVICE_ACCOUNT_JSON }}
          packageName: io.thering.app
          releaseFiles: app-release.aab
          releaseName: ${{ inputs.tag }}
          track: internal
          status: inProgress

And I end up having the same issue everyone is describing (which has occured every time I launched a build from this morning)

Miiite avatar Sep 18 '23 14:09 Miiite

I've tried v1 tag without whatsNewDirectory and works as expected too

- name: Deploy to Play Store
  id: deploy
  uses: r0adkll/upload-google-play@v1
  with:
    serviceAccountJson: service_account.json
    packageName: dev.givaldo.carspecs
    releaseFiles: android/app/build/outputs/bundle/release/app-release.aab
    mappingFile: android/app/build/outputs/mapping/release/mapping.txt
    track: beta
image

It helped me too.

Fudal avatar Sep 18 '23 14:09 Fudal

I'm not using the whatsNew property and still experiencing this issue. I'm using 1.1.1 though

Nek-12 avatar Sep 18 '23 15:09 Nek-12

      - name: upload artifact to playstore
        uses: r0adkll/upload-google-play@v1
        with:
          serviceAccountJsonPlainText: ${{ secrets.SERVICE_ACCOUNT_JSON }}
          packageName: com.a*******e.${{ matrix.flavors }}_app

          releaseFiles: build/app/outputs/bundle/${{ matrix.flavors }}Release/app-${{ matrix.flavors }}-release.aab
          status: draft
          mappingFile: build/app/outputs/mapping/${{ matrix.flavors }}Release/mapping.txt
          debugSymbols: build/app/intermediates/merged_native_libs/${{ matrix.flavors }}Release/out/lib

We do face the same issue.

armanso avatar Sep 18 '23 16:09 armanso

Same issue with 1.1.1, started happening today! --- and then, after several failures, it worked.

valeriyo avatar Sep 18 '23 19:09 valeriyo

I've seen this maybe every other run for a week or so, but it feels more frequent today.

wasnotrice avatar Sep 18 '23 22:09 wasnotrice

I have just published a release that bumps all versions - including androidpublisher. Let me know if you see a change in the status of this.

For now, I will mark this as invalid since it seems to be on Google's side

boswelja avatar Sep 19 '23 04:09 boswelja

@boswelja I have tested v1.1.2 I can confirm it has fixed the issue on my end.

Will monitor to see if the issue shows up again. Thank you!

BashirTowdiee avatar Sep 19 '23 07:09 BashirTowdiee

v1.1.2 didn't help us

miduch avatar Sep 19 '23 12:09 miduch

Alright, version 1.1.2 worked for us, but not on the first try. It took 5-6 attempts to successfully upload the file to the Play Store.

Is it possible to implement a retry option? This way, it could automatically retry the file submission to the Play Store if it fails, with an adjustable amount of time between each retry.

This is the solution that Fastlane has come up with. cc @boswelja

armanso avatar Sep 19 '23 12:09 armanso

For me, this problem started last week. I've been using it for months and never had any problems. Something has definitely changed on Google's side. In my case it always works on the second try.

gustavomaedo avatar Sep 20 '23 00:09 gustavomaedo

I've faced the same issue today, updated to 1.1.2 and it doesn't work. I've tried to re-run the failed upload job 8 times.

    - name: Upload to AlphaTrack
      uses: r0adkll/[email protected]
      with:
        serviceAccountJsonPlainText: ${{ secrets.GP_SERVICE_ACCOUNT_JSON }}
        packageName: com.*************
        releaseFiles: "${{ needs.build.outputs.archiveName }}"
        releaseName: "${{ needs.build.outputs.versionCode }}(${{ needs.build.outputs.versionName }})"
        track: alpha
        status: completed
        inAppUpdatePriority: 5
        whatsNewDirectory: distribution/whatsnew
        mappingFile: mapping.txt
        debugSymbols: debug_symbols/```

Geka000 avatar Sep 20 '23 01:09 Geka000

Looks like fastlane "solved" this issue by introducing a retry mechanism with a max_retries parameter. Maybe this will need to do the same workaround?

Abushawish avatar Sep 20 '23 03:09 Abushawish

I'm not sure how to feel about that solution. Is Google aware of this issue? Does GitHub Actions have a retry mechanism for jobs/workflows already?

boswelja avatar Sep 20 '23 03:09 boswelja

@boswelja Sorry, I just saw your response. I'm not sure if Google is aware of the issue or not, but as everything Google I'm sure they will move at a glacial pace to fix it after ignoring it for a while. Github Actions doesn't offer a retry mechanism besides running a custom run command, which gets very messy and complex.

I put up a PR for a try mechanism if you're interested! No hard feelings at all if you don't feel comfortable with the solution. I would test it locally, but I'm not sure how so I'd recommend keeping that in mind.

Abushawish avatar Sep 20 '23 04:09 Abushawish

@r0adkll any update on this issue ,i am getting "Error: Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project." below are my configs: - name: Deploy to Internal uses: r0adkll/upload-google-play@v1 with: serviceAccountJson: service_account.json packageName: com.packagename releaseFiles: path/to/aab/file/app-production-release.aab track: internal

MahnoorShafique avatar Sep 20 '23 10:09 MahnoorShafique