sign-android-release icon indicating copy to clipboard operation
sign-android-release copied to clipboard

Published 20 hours ago • verified publisher icon r0adkll

Add the ability to sign multiple APKs

Open Abushawish opened this issue 4 years ago • 6 comments

Currently, this Action will only sign the first APK it finds in the release directory. However, occasionally a release will have multiple APKs (for example, different build variants or different architectures). Is it possible for this Action to sign multiple APKs at once?

Abushawish avatar Jul 20 '20 18:07 Abushawish

That shouldn't be too difficult to add

r0adkll avatar Jul 30 '20 13:07 r0adkll

I submitted a PR with this enhancement if you're interested: https://github.com/r0adkll/sign-android-release/pull/14

Abushawish avatar Jul 30 '20 14:07 Abushawish

Bump. I have requested changes to the PR for your request. I've you can apply them I'll happily merge them in.

r0adkll avatar Aug 12 '20 14:08 r0adkll

Any updates?

tiann avatar Jul 02 '21 04:07 tiann

The PR was never completed. I had a look and boldly tried to complete it: https://github.com/r0adkll/sign-android-release/pull/49 I hope it will get accepted.

victorpaleologue avatar Jul 26 '21 15:07 victorpaleologue

Sorry all, life got in the way and my issue/PR has become stale. Please look into Victor's PR https://github.com/r0adkll/sign-android-release/pull/49 :).

Abushawish avatar Jul 26 '21 17:07 Abushawish