Ramses

Results 63 comments of Ramses

Ok, fair point. I will see if I can implement it without the locking. Currently wstunnel always hangs for me when my laptop comes out of suspend, and I need...

Thanks a lot also for the pointers, I'm pretty new still to the rust async stuff, so it's great to get some feedback from you.

I had a shot at implementing this without locking, I pushed a new commit. I made the ping state no longer shared, only the writer now holds that state, and...

Thanks for your feedback. I'm leaving on holidays for 2 weeks and didn't have time to look at this again yet. I will get back to it once I'm back...

Ok, I'll close this PR then, and I'll test the changes with the new release, thanks!

I pushed a commit that should fix the tests. There are others that fail locally for me, but I think that might be an environment issue, let's see. I think...

Hi @terriko, thanks for your feedback! Yeah I do think that we can merge before the refactor indeed, but the scanning loop does feel rather brittle right now, so I...

> Okay, @mastersans has removed the problematic triage entry in #4267 so i think this is safe to merge. We'll likely want to handle old triage more seamlessly (we're still...

I've been working on this today and I may have a solution, I need to clean up the code a bit and then I'll make a PR.