s2
s2 copied to clipboard
r-spatial
Update vendored s2 and abseil and update build system
In the last few months there is a new s2 version which contains some exciting things like a spherical buffer (!!): https://github.com/google/s2geometry/releases/tag/v0.10.0.
With our current build system, it's hard to stay current with updates in Abseil and S2. Getting familiar with Arrow's build system has me appreciating how we might be able to do this with cmake. I think the general concept is to
- keep a copy of Abseil and s2geometry repo checkouts in tools/
- Have configure run cmake and install static libraries to inst/ kind of like winlibs does for Windows
We might still have to make a few modifications to the S2/Abseil sources but I think that compiling a dependency using cmake has different rules than files in the src/ directory.
(Not for this forthcoming release, but the one after!)
Would be nice to upgrade, because existing versions are hopelessly broken for some archs (PowerPC fails).
@paleolimbot Not really sure, had no time to implement the build just for the sake of checking (I am interested to have it in R, not standalone), but from a quick look there were some significant changes.
The current version fails on the first s2 own object (after abseil part is built), but R output is horribly unhelpful. I am not sure why exactly it fails, though I suspect that it pulls a wrong assembler instructions from some header.