r-spatial.org icon indicating copy to clipboard operation
r-spatial.org copied to clipboard

Published 20 hours ago • verified publisher icon r-spatial

Review rpygeo

Open be-marc opened this issue 5 years ago • 13 comments

be-marc avatar Mar 10 '19 16:03 be-marc

Is this blog ready to go?

edzer avatar Mar 30 '19 16:03 edzer

It's out: https://www.r-spatial.org/r/2019/03/20/rsaga-1.0.0 https://twitter.com/edzerpebesma/status/1112049988245381121

edzer avatar Mar 30 '19 20:03 edzer

@edzer something went wrong here, the post is about RPyGeo and not RSAGA. The latter has been released in November 18 already. @be-marc wasn't there already a blog post about RSAGA before? I'm on the phone right now, should check in detail in the next days.

pat-s avatar Mar 31 '19 22:03 pat-s

Yes this is the old RSAGA blog post. I wrote it in March 2018.

be-marc avatar Mar 31 '19 22:03 be-marc

Sorry about that. Shall I remove it?

edzer avatar Apr 01 '19 09:04 edzer

No worries! Don't remove, just dating it back to its original post date is fine. I do not see the original post date anymore in the list but it should be in the git hist?

I'll try to finish the review here ASAP.

pat-s avatar Apr 01 '19 21:04 pat-s

@be-marc Good work.

Please

  • remove the outdated file from the PR
  • update the post date
  • take a final look at the post

and then we're good to go here I think :+1:

pat-s avatar Jun 01 '19 20:06 pat-s

@edzer Ready

be-marc avatar Jun 03 '19 15:06 be-marc

ping @edzer

pat-s avatar Jun 17 '19 20:06 pat-s

Thanks. Since this needs a working ArcGIS license, which I don't have (on my computer), could you please also upload the resulting .markdown file in the _posts directory?

edzer avatar Jun 17 '19 20:06 edzer

@edzer Done

be-marc avatar Jun 20 '19 16:06 be-marc

Thanks. Is this ready to go live?

edzer avatar Jul 21 '19 11:07 edzer

@edzer The .md file is missing because the makefile does not work for me. Maybe you can run it? You don't need an ArcGIS license because the code chunks are set to eval=FALSE.

be-marc avatar Jul 21 '19 18:07 be-marc