mapview icon indicating copy to clipboard operation
mapview copied to clipboard

Issue in html rendering when using pipe?

Open oliviergimenez opened this issue 5 years ago • 2 comments

Hi there, Congrats on an awesome package! I have encountered a small issue when rendering the output of an interactive map with R Markdown and xaringan in html. I think it is due to the use of the pipe operator with mapview, which screws things up. Here is a reproducible example, with the slides there. In https://github.com/oliviergimenez/reprex_mapview/tree/master/libs, the directory corresponding to the pipe is "_-founded" whereas that of the non-pipe call to mapview, "breweries-founded", seems more legit. Cheers, Olivier

oliviergimenez avatar Oct 30 '20 22:10 oliviergimenez

Thanks! Very useful. The problem is this line in leafem. Given that we attach the data to the html, we need to take care about naming. I think we will need to get away from using LayerId as the filename. Then things should work.

Hope to have a fix soon.

tim-salabim avatar Oct 31 '20 09:10 tim-salabim

Wow, you're fast ! Glad you've located the issue.

oliviergimenez avatar Oct 31 '20 10:10 oliviergimenez