mapview icon indicating copy to clipboard operation
mapview copied to clipboard

[suggestion] remove/update stale "master" github branch

Open lbusett opened this issue 5 years ago • 3 comments

Hi @tim-salabim ;

Not a big deal, but I noticed last week that the master github branch of mapview is somehow in a "stale" state (more than 2 years old)

Would you consider removing it (or mayb updating it to the last "stable" mapview release)? I know I should use the @develop branch to install from github, but sometimes I forget to add the @develop specifier, and I accidently try to install the "master" branch.

Lorenzo

PS: As a side note "mapview" website (wrongly) reports v 2.6.11 as the last released version.

lbusett avatar May 25 '20 09:05 lbusett

In case master is not used, I'd suggest to rename develop into master and remove develop.

edzer avatar May 25 '20 09:05 edzer

Thanks for bringing this up! This is me being lazy... I think I should do as @edzer suggests and merge develop into master and remove develop. I once thought it would be nice to have a stable branch and a develop branch, but I now realise that CRAN releases pretty much substitute having a stable branch here. So instead of master/develop we have CRAN/github which I think is the model most people follow anyway (and I do in all the later packages).

Note to self: change active branch back to master in settings!!!

tim-salabim avatar May 25 '20 10:05 tim-salabim

I've just merged develop into master and reset master to be the default branch on github. Also, @pat-s has exercised some of his magic to update the CI pipeline to use GH (instead of travis) which also means that the website should now be up-to-date too. I'll delete the develop branch as soon as I feel that I haven't messed up anything.

tim-salabim avatar Aug 21 '20 14:08 tim-salabim